Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update README.md with screenshots #420

Merged
merged 4 commits into from
Jan 7, 2024
Merged

Fix: update README.md with screenshots #420

merged 4 commits into from
Jan 7, 2024

Conversation

mwithi
Copy link
Member

@mwithi mwithi commented Dec 30, 2023

Fix screenshots

@mwithi
Update README.md
81d2890 
Fix screenshots
@mwithi mwithi changed the title Update README.md Chore: update README.md Dec 30, 2023
@mwithi mwithi changed the title Chore: update README.md Fix: update README.md with screenshots Dec 30, 2023
dbmalkovsky
dbmalkovsky approved these changes Dec 30, 2023
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as "OH 2.0" isn't going to confuse anyone on the Swagger API Documentation image page.

@mwithi
Copy link
Member Author

mwithi commented Dec 30, 2023

LGTM as long as "OH 2.0" isn't going to confuse anyone on the Swagger API Documentation image page.

Till now it has actually passed quite ignored... I would keep it just as reminder we are pointing to a new API layer for future applications, otherwise we can just rename it to "Open Hospital Api Documentation" ?

@dbmalkovsky
Copy link
Collaborator

LGTM as long as "OH 2.0" isn't going to confuse anyone on the Swagger API Documentation image page.

Till now it has actually passed quite ignored... I would keep it just as reminder we are pointing to a new API layer for future applications, otherwise we can just rename it to "Open Hospital Api Documentation" ?

You are the boss 😏 Do what you think is best.

@mwithi
Copy link
Member Author

mwithi commented Dec 30, 2023

You are the boss 😏 Do what you think is best.

I was already doing :) found also that version and license need to be aligned with the github project

dbmalkovsky
dbmalkovsky reviewed Dec 30, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
dbmalkovsky
dbmalkovsky approved these changes Dec 30, 2023
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM with minor changes

@mwithi @dbmalkovsky
Apply suggestions from code review
dc86af3 
Co-authored-by: David B Malkovsky <[email protected]>
@mwithi mwithi merged commit fcc7215 into develop Jan 7, 2024
0 of 2 checks passed
@mwithi mwithi deleted the mwithi-fix-screenshots branch January 7, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbmalkovsky dbmalkovsky dbmalkovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mwithi @dbmalkovsky