Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remove no longer existing endpoint after OHSC-92 #229

Merged
merged 3 commits into from
Mar 26, 2023
Merged

Fix: remove no longer existing endpoint after OHSC-92 #229

merged 3 commits into from
Mar 26, 2023

Conversation

mwithi
Copy link
Member

@mwithi mwithi commented Mar 23, 2023 •
edited
Loading

Fix: remove no longer existing endpoint after OHSC-92

@mwithi mwithi requested a review from dbmalkovsky March 23, 2023 19:54
@mwithi mwithi changed the title Remove no longer existing endpoint Fix: remove no longer existing endpoint after OHSC-92 Mar 23, 2023
dbmalkovsky
dbmalkovsky approved these changes Mar 25, 2023
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the method is restored and my two changes accepted I then Approve this PR.

@mwithi
Copy link
Member Author

mwithi commented Mar 26, 2023

Given the method is restored and my two changes accepted I then Approve this PR.

Done. Please check now. Thanks!

dbmalkovsky
dbmalkovsky approved these changes Mar 26, 2023
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mwithi mwithi merged commit 9d3364f into develop Mar 26, 2023
@mwithi mwithi deleted the fix_broken_tests_after_OHCS-92 branch March 26, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbmalkovsky dbmalkovsky dbmalkovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mwithi @dbmalkovsky