Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant field name #408

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Conversation

xla
Copy link
Contributor

@xla xla commented Jul 2, 2020

This is coming up in automated integrations and in local tooling as
a warning. To reduce the noise it causes we remove the redundant field
assignment.

Ref: https://rust-lang.github.io/rust-clippy/master/#redundant_field_names


  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

This is coming up in automated integrations and in local tooling as
a warning. To reduce the noise it causes we remove the redundant field
assignment.

Ref: https://rust-lang.github.io/rust-clippy/master/#redundant_field_names
@xla xla added enhancement New feature or request light-client Issues/features which involve the light client ci Related to continuous integration labels Jul 2, 2020
@xla xla self-assigned this Jul 2, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #408 into master will decrease coverage by 0.0%.
The diff coverage is 5.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #408     +/-   ##
========================================
- Coverage    28.2%   28.2%   -0.1%     
========================================
  Files         130     130             
  Lines        5383    5386      +3     
  Branches     1663    1665      +2     
========================================
  Hits         1519    1519             
- Misses       2795    2798      +3     
  Partials     1069    1069             
Impacted Files Coverage Δ
light-client/src/fork_detector.rs 0.0% <0.0%> (ø)
light-client/src/light_client.rs 31.0% <ø> (ø)
light-client/src/supervisor.rs 0.0% <0.0%> (ø)
light-client/src/predicates.rs 75.2% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e4de1...06e2a04. Read the comment docs.

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@liamsi liamsi merged commit 9adad9a into master Jul 2, 2020
@liamsi liamsi deleted the xla/fix-clippy-warning branch July 2, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration enhancement New feature or request light-client Issues/features which involve the light client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants