Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Apply suggestions from #1212 code review #1215

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

thanethomson
Copy link
Contributor

Follows from #1212.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

Codecov Report

Merging #1215 (cc20ca9) into main (e830f85) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #1215     +/-   ##
=======================================
- Coverage   63.9%   63.9%   -0.1%     
=======================================
  Files        253     253             
  Lines      21636   21636             
=======================================
- Hits       13844   13838      -6     
- Misses      7792    7798      +6     
Impacted Files Coverage Δ
proto/src/serializers/bytes.rs 51.6% <ø> (ø)
testgen/src/vote.rs 84.0% <0.0%> (-1.7%) ⬇️
testgen/src/header.rs 82.9% <0.0%> (-1.2%) ⬇️
testgen/src/validator.rs 86.7% <0.0%> (-0.8%) ⬇️
light-client-verifier/src/types.rs 38.1% <0.0%> (-0.6%) ⬇️
tendermint/src/node.rs 63.9% <0.0%> (ø)
config/src/config.rs 54.9% <0.0%> (+0.1%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mzabaluev mzabaluev merged commit f62a000 into main Oct 22, 2022
@mzabaluev mzabaluev deleted the thane/1212-docs-follow-ups branch October 22, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants