Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Remove wee_alloc optional dependency #1201

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

thanethomson
Copy link
Contributor

Closes #1192.

wee_alloc was an optional dependency and an optimization anyways.


  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

Codecov Report

Merging #1201 (a6db49c) into main (e7f4978) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #1201     +/-   ##
=======================================
- Coverage   67.0%   67.0%   -0.1%     
=======================================
  Files        219     219             
  Lines      20709   20708      -1     
=======================================
- Hits       13895   13892      -3     
- Misses      6814    6816      +2     
Impacted Files Coverage Δ
light-client-js/src/lib.rs 1.8% <ø> (-1.9%) ⬇️
light-client-verifier/src/types.rs 38.1% <0.0%> (-0.9%) ⬇️
testgen/src/header.rs 83.5% <0.0%> (-0.6%) ⬇️
tendermint/src/node.rs 63.8% <0.0%> (-0.2%) ⬇️
testgen/src/validator.rs 87.5% <0.0%> (+0.7%) ⬆️
testgen/src/vote.rs 84.8% <0.0%> (+0.8%) ⬆️
tendermint/src/timeout.rs 85.9% <0.0%> (+1.7%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thanethomson thanethomson merged commit 3b89cf1 into main Sep 23, 2022
@thanethomson thanethomson deleted the thane/1192-rm-wee_alloc branch September 23, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2022-0054: wee_alloc is Unmaintained
2 participants