Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Correct Serialization of google::protobuf::*Value Types #63

Merged
merged 2 commits into from
Aug 23, 2022
Merged

feat: Correct Serialization of google::protobuf::*Value Types #63

merged 2 commits into from
Aug 23, 2022

Conversation

rise0chen
Copy link
Contributor

Warn: BytesValue can't work

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, what was the reason for not adding BytesValue?

@rise0chen
Copy link
Contributor Author

BytesValue contain prost::bytes::Bytes, It can't serializa

@tustvold tustvold mentioned this pull request Aug 23, 2022
@tustvold tustvold added the automerge Put in the merge queue label Aug 23, 2022
@kodiakhq kodiakhq bot merged commit 1e746f9 into influxdata:main Aug 23, 2022
@tustvold
Copy link
Contributor

I'm going to get this in, thank you 👍

Feel free to open a follow up PR to add BytesValue support if you would like to 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Put in the merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants