Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support URL-safe base64 strings (#22) #26

Merged
merged 1 commit into from
Jan 13, 2022
Merged

feat: support URL-safe base64 strings (#22) #26

merged 1 commit into from
Jan 13, 2022

Conversation

tustvold
Copy link
Contributor

There might be smarter ways to detect this, but this was the quickest solution I could come up with.

Closes #22

@tustvold tustvold mentioned this pull request Jan 13, 2022
Closed
crepererum
crepererum approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@crepererum crepererum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using a trail-error heuristic is OK here.

@tustvold tustvold added the automerge Put in the merge queue label Jan 13, 2022
@kodiakhq kodiakhq bot merged commit 91553a5 into main Jan 13, 2022
@tustvold tustvold mentioned this pull request Mar 7, 2022
Merged
@alamb alamb deleted the url-safe-bytes branch July 9, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crepererum crepererum crepererum approved these changes

Assignees
No one assigned
Labels
automerge Put in the merge queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept url-safe base64 encoding for bytes
2 participants
@tustvold @crepererum