Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): improve flux function tests #433

Merged
merged 2 commits into from
Apr 19, 2022
Merged

chore(core): improve flux function tests #433

merged 2 commits into from
Apr 19, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Apr 9, 2022 •
edited
Loading

This PR adds tests for parameter escaping in a flux tagged template, given the feedback from #432.

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are in semantic format

@sranka sranka added this to the 1.25.0 milestone Apr 9, 2022
@sranka sranka marked this pull request as ready for review April 9, 2022 06:47
bednar
bednar approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍻

@sranka sranka merged commit 587b959 into master Apr 19, 2022
@sranka sranka deleted the chore/flux_test_432 branch April 19, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

@vlastahajek vlastahajek Awaiting requested review from vlastahajek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sranka @bednar