Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libflux): only compile flux-core with strict if enabled in flux #5494

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

davidkna
Copy link
Contributor

Checklist

By inheriting the value of strict it is simpler to build flux in cases where warnings are acceptable without needing to patch the flux-core Cargo.toml or source.

The changes can be tested by adding a dead function to flux-core e.g. fn dead_code() {} and compiling flux with --no-default-features.

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

@davidkna davidkna requested a review from a team as a code owner June 13, 2024 07:43
@crepererum crepererum merged commit 83f0400 into influxdata:master Jul 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants