Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): rename arm rpms with yum-compatible names #5792

Merged
merged 4 commits into from
Aug 29, 2021

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Aug 6, 2021

Fixes #5790

Follow-on for influxdata/influxdb#21749

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • Any changes to etc/Dockerfile_build have been pushed to DockerHub, and the changes have been added to .circleci/config.yml

@sranka sranka requested a review from ivankudibal August 6, 2021 04:23
@sranka sranka self-assigned this Aug 6, 2021
@sranka sranka added this to the 1.9.1 milestone Aug 6, 2021
@sranka sranka removed the request for review from ivankudibal August 6, 2021 04:27
@sranka
Copy link
Contributor Author

sranka commented Aug 6, 2021

@ivankudibal a build script has changed in this PR. Please build and push a new docker image as you lastly did for #5754.

@sranka sranka assigned ivankudibal and unassigned sranka Aug 6, 2021
@ivankudibal ivankudibal self-requested a review August 24, 2021 12:37
Copy link
Contributor

@ivankudibal ivankudibal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@sranka
Copy link
Contributor Author

sranka commented Aug 26, 2021

ok

A build script has changed in this PR. @ivankudibal Can you please build and push a new docker image as you lastly did for #5754.

@ivankudibal
Copy link
Contributor

ivankudibal commented Aug 28, 2021

ok

A build script has changed in this PR. @ivankudibal Can you please build and push a new docker image as you lastly did for #5754.

I have pushed a new build image from this branch, the image appears to have as same sha1 as the previous build image. However, both the new aarch64_centos and armv7hl_centos filenames have been produced correctly.

@sranka sranka merged commit 32f81db into master Aug 29, 2021
@sranka sranka deleted the 5790/rpm_arm64_rename branch August 29, 2021 16:48
@sranka
Copy link
Contributor Author

sranka commented Aug 31, 2021

@ivankudibal the new distributions appear properly in nightly builds:

Uploading /home/circleci/project/build/linux/arm64/chronograf-nightly.aarch64.rpm (32 MB): DONE
Uploading /home/circleci/project/build/linux/armhf/chronograf-nightly.armv7hl.rpm (31 MB): DONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Chronograf armhf and arm64 rpms
2 participants