fix: explicitly enable wasi on smartengine uses #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digikata
force-pushed
the
ac/force-enable-wasi
branch
from
e4c345b
to
088838e
Compare
digikata
force-pushed
the
ac/force-enable-wasi
branch
2 times, most recently
from
853f4fa
to
6a8ba57
Compare
remove feature flag, wasi is always on if the engine is on
digikata
force-pushed
the
ac/force-enable-wasi
branch
from
6a8ba57
to
0263860
Compare
nacardin
reviewed
May 6, 2024
morenol
reviewed
May 7, 2024
build_smartmodules already adds it
EstebanBorai
approved these changes
May 7, 2024
morenol
approved these changes
May 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nacardin
approved these changes
May 7, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2024
* fix: explicitly use wasi on smartengine uses remove feature flag, wasi is always on if the engine is on * chore: build alignment to wasm32-wasi * chore: disable cli smoke test for dev-cli + stable cluster * chore: restore versions on dep paths * fix: repeated line * fix: remove redundant rustup target add build_smartmodules already adds it * chore: one last missed version
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2024
* fix: explicitly use wasi on smartengine uses remove feature flag, wasi is always on if the engine is on * chore: build alignment to wasm32-wasi * chore: disable cli smoke test for dev-cli + stable cluster * chore: restore versions on dep paths * fix: repeated line * fix: remove redundant rustup target add build_smartmodules already adds it * chore: one last missed version
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2024
* fix: explicitly use wasi on smartengine uses remove feature flag, wasi is always on if the engine is on * chore: build alignment to wasm32-wasi * chore: disable cli smoke test for dev-cli + stable cluster * chore: restore versions on dep paths * fix: repeated line * fix: remove redundant rustup target add build_smartmodules already adds it * chore: one last missed version
fraidev
pushed a commit
to fraidev/fluvio
that referenced
this pull request
May 23, 2024
* fix: explicitly use wasi on smartengine uses remove feature flag, wasi is always on if the engine is on * chore: build alignment to wasm32-wasi * chore: disable cli smoke test for dev-cli + stable cluster * chore: restore versions on dep paths * fix: repeated line * fix: remove redundant rustup target add build_smartmodules already adds it * chore: one last missed version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.