Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New features and support for older versions #8

Closed
wants to merge 4 commits into from

Conversation

PrashamTrivedi
Copy link
Contributor

Added three new features.

  1. Database version (can be shown in subtitle
  2. Menu for search tables
  3. Menu for copy database in memory card for further testing. (Can be used with ADB pull to copy it in PC and run it in Sqlite editor)

Added Support for older versions using support fragments and support fragment manager. For Preference Fragment I have used code from here

@PrashamTrivedi
Copy link
Contributor Author

The explanation behind the changes are explained in this post

@reisub reisub self-assigned this Feb 14, 2015
}
}
}
//apply plugin: 'maven'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PrashamTrivedi Please don't change/comment the deploy code, we need it to deploy DbInspector to maven central.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry forgot to mention that. It was problemetic to run the code with that
code. Will change all the things and do pull request again.

For the indention and others if you can send me the settings you use, so I
can change accordingly before submitting another pull request

On Sat 14 Feb, 2015 2:06 pm Dino Kovač [email protected] wrote:

In dbinspector/build.gradle
#8 (comment)
:

  •                name 'The Apache Software License, Version 2.0'
    
  •                url 'http:https://www.apache.org/licenses/LICENSE-2.0.txt'
    
  •                distribution 'repo'
    
  •            }
    

- }

  •        developers {
    
  •            developer {
    
  •                id 'reisub'
    
  •                name 'Dino Kovač'
    
  •            }
    
  •        }
    
  •    }
    
  • }
    -}
    +//apply plugin: 'maven'

@PrashamTrivedi https://github.com/PrashamTrivedi Please don't
change/comment the deploy code, we need it to deploy DbInspector to maven
central.


Reply to this email directly or view it on GitHub
https://github.com/infinum/android_dbinspector/pull/8/files#r24713280.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this one:
https://gist.github.com/reisub/a9283a04e46fe471cbc5

Here are some instructions how to add the code style:
http:https://metova.com/tech/blog/2014/08/27/how-to-import-the-official-android-code-style-to-android-studiointellij/

I also took this opportunity to re-indent all the code in the project so we are consistent.

@reisub
Copy link
Contributor

reisub commented Feb 14, 2015

Hi @PrashamTrivedi , thank you for your contribution to this project. You implemented some useful features and even explained them in a blog post!

However, you were a bit too aggressive with your code reformatting and your changes are difficult to see. Please fix this and make a new pull request.

Here is a good example of a clean pull request:
https://github.com/infinum/android_dbinspector/pull/1/files

As you can see the difference in readability is huge!
If you need any help, let me know.

@reisub reisub closed this Feb 14, 2015
@PrashamTrivedi
Copy link
Contributor Author

I have applied your code style and updated the repository. But I fear there is something missing in the code style provided by you. Comparing my forked TableFragment and Original TableFragment, we can see method names re-ordered, and some line breaks are not consistent.

Usually I use AOSP code style with some of my modifications, which I think caused inconsistencies between our indentations, method arrangement etc. And even after reapplying the styles I fear about having difficulties in merging. I am -anyway- creating a pull request hoping it can be merged without difficulties, but in case it does not happen, can we temporarily switch to AOSP Code style?

@reisub
Copy link
Contributor

reisub commented Feb 16, 2015

The code style is fine, it's just that we at Infinum have method rearranging disabled during reformat to minimize merge conflicts.
The pull request is now much cleaner, I will review it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants