Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: custom table format (long text, timestamp, etc.) #51

Closed
wants to merge 10 commits into from

Conversation

orionlee
Copy link
Contributor

@orionlee orionlee commented Mar 27, 2019

Allows developers to specify custom formatting on per table/column level, which can be used support:

  • display of long text (limit max-width of the column and truncate the text), one way for Impractical with a lot of text in database #31
  • display timestamp (unix epoch in long) in human-readable format
  • human-friendly display of floating point numbers, e.g., limit to 2 decimal places.

See the changes in ExampleApp.java for usage.

@reisub
Copy link
Contributor

reisub commented Mar 28, 2019

@orionlee Hi Sam, great idea and thanks for taking the time to contribute, we'll review as soon as we can.

@reisub reisub requested a review from bojankoma March 28, 2019 07:59
@orionlee orionlee force-pushed the feature_custom_table_format branch from a816ad7 to db9805e Compare March 28, 2019 18:00
@orionlee
Copy link
Contributor Author

The codes are stable enough for review now.

@bojankoma
Copy link
Collaborator

After long and careful deliberation, I'll have to respectively decline this PR.
Reasoning behind this decision is that I don't want DbInspector to process what is written down in database in any way.
Taking that responsibility and guaranteeing that content is correct is not in the scope of this library.
However, I do recognise the need to represent data in a more human readable manner.
There is an issue already open on this subject and we can continue to discuss how to approach and solve this problem.
Thank you for your interest and work, I do hope to see some more.

@bojankoma bojankoma closed this Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants