Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onAbort function to toolbox meta #752

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Add onAbort function to toolbox meta #752

merged 1 commit into from
Feb 4, 2022

Conversation

ugur-eren
Copy link
Contributor

In my project I'm working with temporary files and needed this solution. And since there's an issue about it, I wanted to open a PR. (This is my first open-source PR, I'm sorry if there's an issue about it.)

I've never worked with signals before, let me know if I have a mistake that needs to be resolved.
I've used the signals described in node.js and GNU documentation.

onAbort preview

Fixes #463

Executes the given callback when a termination signal is received.
Fixes #463
@jamonholmgren jamonholmgren merged commit 7e6c21b into infinitered:master Feb 4, 2022
@jamonholmgren
Copy link
Member

Great work @ugur-eren -- and congrats on your first open source PR! Hopefully one of many. :-)

infinitered-circleci pushed a commit that referenced this pull request Feb 4, 2022
# [5.1.0](v5.0.0...v5.1.0) (2022-02-04)

### Features

* **meta:** Adds onAbort callback to toolbox.meta ([#752](#752) by [@ugur-eren](https://github.com/ugur-eren)) ([7e6c21b](7e6c21b)), closes [#463](#463)
@infinitered-circleci
Copy link

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ugur-eren
Copy link
Contributor Author

Thanks!
I just noticed ci:test is failed. Is it my mistake? I can create a new typescript cli but I'm still not sure.

@jamonholmgren
Copy link
Member

@ugur-eren I re-triggered the CI job. That's running on Windows, so you might want to take a look at it in Windows and see if there's something going on.

Just FYI, I'm on-stream working on putting Gluegun into a community-supported mode. Feel free to join if you want!

@ugur-eren ugur-eren deleted the feature/onAbort-function branch February 4, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easy way to handle cleanup on user initiated premature termination
3 participants