Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary directory #756

Closed
ElonVolo opened this issue Apr 13, 2022 · 3 comments · Fixed by #757
Closed

Temporary directory #756

ElonVolo opened this issue Apr 13, 2022 · 3 comments · Fixed by #757
Labels

Comments

@ElonVolo
Copy link
Contributor

Note that Gluegun is community-supported and the core team will not be adding new features other than those submitted as PRs by the community.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. Gluegun doesn't work very well when [...]

I think it would be useful for gluegun's filesystem toolbox item to include functionality for creating directories (maybe temporary files to, but at least temporary directories to start with)

Describe the solution you'd like
A clear and concise description of what you want to happen.

Expose fs-jetpack's tmpDir to the filesystem toolbox.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

While there's several differently approaches that could be taken (separately import/require fs-jetpack, using node.js fs.mkdtempSync, etc) it would be nice to have a handy shortcut to not have to look up those api's and have something that leverages the toolbox approaches consistent interface. The advantage of using gluegun in general is avoiding the "crap, I have to look this up again across a zillion modules' documentations" problem.

Additional context
Add any other context or screenshots about the feature request here.

@jamonholmgren
Copy link
Member

Good idea. I’ll review and merge a PR to this effect!

@ElonVolo
Copy link
Contributor Author

It turns out the functionality should already be available in the most current fs-jetpack, it's just that the version of fs-jetpack is about two years old, and when I bumped up the version of fs-jetpack to 4.3.1 the API call appeared.

ElonVolo added a commit to ElonVolo/gluegun that referenced this issue Apr 18, 2022
infinitered-circleci pushed a commit that referenced this issue Apr 19, 2022
## [5.1.1](v5.1.0...v5.1.1) (2022-04-19)

### Bug Fixes

* **deps:** Update dependency fs-jetpack to 4.3.1 - fixes [#756](#756) ([#757](#757) by @ElonVolo) ([58e378a](58e378a))
@infinitered-circleci
Copy link

🎉 This issue has been resolved in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants