Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Remove color scheme query from svgs and always use fill: #fff #83

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

drikusroor
Copy link
Contributor

This PR aims to fix the following things:

  • The SVGs still had a fill color based on the preferred color-scheme (system preference based), which caused the SVGs to have the wrong fill when your OS/System preferred light mode (on dark mode it worked fine). This color-scheme based fill has been removed and set to white (#fff) in all cases.
  • As the html structure of the list items slightly changed since a recent PR, the colored numbered list items did not have rounded borders on all sides anymore. This has been fixed by updating the selector that applies the border radius in print mode.

@drikusroor drikusroor added bug Errors, language mistakes, broken links, etc. summer-2023 Improvements and fixes that Infi is planning to do in the summer of 2023 labels Aug 22, 2023
@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for the-infi-way ready!

Name Link
🔨 Latest commit ae708e4
🔍 Latest deploy log https://app.netlify.com/sites/the-infi-way/deploys/64e487f7da0bb40008a9fb52
😎 Deploy Preview https://deploy-preview-83--the-infi-way.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@drikusroor drikusroor self-assigned this Aug 22, 2023
@LucaScorpion LucaScorpion merged commit 64572ac into infi-nl:main Aug 22, 2023
4 checks passed
@drikusroor drikusroor deleted the fix/svg-color-scheme-query branch August 22, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Errors, language mistakes, broken links, etc. summer-2023 Improvements and fixes that Infi is planning to do in the summer of 2023
Development

Successfully merging this pull request may close these issues.

2 participants