A11Y improvements (especially to the Dutch texts) #69
Conversation
✅ Deploy Preview for the-infi-way ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
LET OP: ik heb overal <span lang="en"> en toegevoegd, maar de resultaten zijn nog niet helemaal eenduidig. Ik ga er maandag met Sterre naar kijken. |
|
Cheers! I had the same question @dirkinfi - does this add a significant improvement? I'd presume that screen readers are very capable of dealing with loan words, and that they'd ignore short snippets in another PS. There's an open discussion in #63 whether we want to go back with this entire open source project to Dutch as the default language, but if we could for now stick to English conversations that would be appreciated 🙏🏻 |
|
@jeroenheijmans screen readers do NOT handle loanwords gracefully (you'll get horrible steenkolenengels), and it's not a big amount of work to add the language-tag. That said, if found out that VoiceOver (the Apple default screenreader) does not always handle the tagged snippets correctly either. So as a learning experience, Sterre is asking Job if this is something we can improve or not. But adding the correct tags is in my opinion a small task, and you should (imho) get into the habit of adding them. |
|
(BTW I'm new to interfering with code and working in Github, so feel free to talk to me if I do this 'wrong'. For example, I have no idea what the desired opknipstrategie is for pull requests. Personally I'd separate the line-thickness fix from the language-tag-fix, but Steven recommended putting them in one branch 'a11y changes'.) |
|
Thx @dirkinfi for going along with the GitHub process! So far so good, and many choices (like how granular things should be) are also subjective, so asking around is often a good solution. Let's discuss the status of the PR in person some time soon, and then we'll bring back our conclusions to GitHub for visibility? We can probably finish this work together and get the improvements merged. |
|
Update: Discussed the PR offline with Dirk, will summarize here a bit later and help get the changes across. We also find several other improvements (some A11Y related) which I'll put into fresh tickets. |
Lijndikte aangepast voor zichtbaarheid Afstand tot de tekst wat groter gemaakt voor leesbaarheid
Zodat ie door een screenreader met het juiste accent wordt uitgesproken
Zodat ie door een screenreader met het juiste accent wordt uitgesproken
Zodat de screenreader al onze engelse termen goed uitspreekt
Discussed offline with Dirk, the originator of this PR: wherever possible it's best if the Dutch text doesn't use loan words, for sure for Screen Readers. When it's not possible to use Dutch, we can use spans to switch the narrator to English pronunciation.
bab2917
to
789710a
Compare
|
After some discussion and investigation together with @dirkinfi we found that:
Additionally:
I'll ask a second person to double check the end result, but I think it's now good to go. |
Lijndikte aangepast voor zichtbaarheid
Afstand tot de tekst wat groter gemaakt voor leesbaarheid