Not friendly to non-ascii data #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It forces it for turtle, but not for JSON-LD -- which can definitely be UTF-8. |
satra
reviewed
Jun 5, 2018
| @@ -91,7 +91,7 @@ def main(argv): | |||
| if args.jsonld: | |||
| f.write(project.serializeJSONLD()) | |||
| else: | |||
| f.write(project.serializeTurtle()) | |||
| f.write(project.serializeTurtle().decode('ASCII')) | |||
There was a problem hiding this comment.
pynidm is py3 only. why would this be necessary. were you testing on python 3 or 2?
There was a problem hiding this comment.
I was just moving the decode('ASCI') away -- not introducing it. I am not sure why one wants this, but it certainly is detrimental for JSON-LD. If you are confident that it being there at all (and not just in the way of JSON-LD) is the real bug, I have no objections to wipe it out entirely. And no, this is all PY3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Russia is our friend!
from participants.tsv (valid UTF-8)
leads to
the decode part is the issue.