Suggestion: Use Macros appropriately

[elbrujohalcon]

rule

Macros should not be used as abbreviations. Also, no code should be allowed in macros, except for extenuating circumstances which must be documented.

##### bad
-define(IS_VALID_SERVICE(__Service), lists:member(__Service, pg2:which_groups())).
-define(IS_VISIBLE_SERVICE(__Service), (lists:keyfind(__Service, 1, application:which_applications()) =/= false)).

reasoning

Having logic in macros obscures its meaning. If having the code there complicate the logic, or duplicates code, or the logic is not related to the location the macro is invoked, then the macro'ed code should be in a function, with a proper semantic name.

[igaray]

-1
I would actually go for Loic's "Don't use macros", period.
Use functions instead.

[unbalancedparentheses]

I never understood why people use so many macros. Functions are better, even for abbreviations.

[igaray]

Furthermore, some common exceptions may be added to relax restrictions:
"Do not use macros, except to add meaning to magic numbers (non-configurable values pertaining to the code's correct functioning) and when you require that arguments not be evaluated."