Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer the git protocol over others when specifying dependency URLs #27

Closed
igaray opened this issue Dec 3, 2014 · 4 comments · Fixed by #37
Closed

Prefer the git protocol over others when specifying dependency URLs #27

igaray opened this issue Dec 3, 2014 · 4 comments · Fixed by #37

Comments

@igaray
Copy link
Member

igaray commented Dec 3, 2014


Prefer the git protocol over others when specifying dependency URLs

When specifying dependencies

%% bad
{deps,
  [{lager, "2.*", {git, "[email protected]:basho/lager.git", "2.0.0"}},
  {jiffy,   "0.*", {git, "https://github.com:davisp/jiffy.git", "0.11.3"}}
}.

%% good
{deps,
  {lager, "2.*", {git, "git:https://github.com/basho/lager.git", "2.0.0"}},
  {jiffy,   "0.*", {git, "git:https://github.com:davisp/jiffy.git", "0.11.3"}}
}.
Reasoning

SSH requires authentication.
https may require authentication (bitbucket does, github doesn't), but sometimes doesn't.
In addition, https is chatty compared to the git protocol, optimized for cloning repos.
The git protocol's main disadvantage is that it doesn't support authentication, which is a plus for CI systems.

@elbrujohalcon
Copy link
Member

+1

@jfacorro
Copy link
Contributor

+1

1 similar comment
@amilkr
Copy link
Contributor

amilkr commented Dec 11, 2014

+1

@elbrujohalcon
Copy link
Member

@igaray enough upvotes… turn this issue into a PR, please.

igaray added a commit that referenced this issue Dec 17, 2014
igaray added a commit that referenced this issue Dec 17, 2014
igaray added a commit that referenced this issue Dec 17, 2014
igaray added a commit that referenced this issue Dec 17, 2014
igaray added a commit that referenced this issue Dec 17, 2014
igaray added a commit that referenced this issue Dec 17, 2014
elbrujohalcon pushed a commit that referenced this issue Dec 17, 2014
[Closes #27] Prefer git protocol for deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants