Detect offline proxies, updated docstrings #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #21.
Added a new argument to pass in a list of types that will force proxies that have a pre-existing 'proxy path' to be re-rendered if their proxy status is in this list. By default this list includes 'Offline' and 'None', but it can include a specific resolution to force a rerender.
What may make sense is splitting this into another handler that allows blacklisting/whitelisting of resolutions that force a rerender of an already linked proxy. Perhaps a flag like
always_rerender_mismatched_resolutionto always rerender linked proxies that have a resolution different to the resolution of the proxy settings in RPE.