Cast times and amplitude inputs to np array in case they are supplied as list. #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is more convenient to supply times and amplitudes as Python list instead of np.array to avoid boilerplate. In fact, it is what is done in "Tong et al. A framework for validating open-source pulse sequences. MRM. 2022. (https://doi.org/10.1016/j.mri.2021.11.014)", so IRSE and TSE sequences are currently failing in PyPulseq 1.4. This PR aims to introduce this convenience, and make this branch more "backwards compatible".
Usage of np.asarray is almost free in this context, because:
PS: IMHO, every function that gets an ArrayLike, should have asarray casts for their respective inputs.