Several bug fixes in Sequence, add_gradients, make_trapezoid, and rotate
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otate`: - Bypass code for `restoreAdditionalShapeSamples` did not include `grad.first` and `grad.last` - `make_arbitrary_grad` was not available as `pp.make_arbitrary_grad` - `add_gradients`' detection of arbitrary gradients was incorrect for Python's 0-based indexing - `add_gradients` handling of non-unique times was broken - `make_trapezoid` incorrectly checked and reported the minimum duration for gradients specifying area and duration (also fixed in local upstream MATLAB pulseq) - `rotate` did not have a system parameter - `rotate` used the incorrect channel for gradient on the second rotation axis - Small change in `add_gradients` to accept a single gradient (i.e. for cases where a variable number of gradients are added), which also allowed a minor cleanup in `rotate`
c39914d
to
a4f1d67
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bypass code for
restoreAdditionalShapeSamplesdid not includegrad.firstandgrad.lastmake_arbitrary_gradwas not available aspp.make_arbitrary_gradadd_gradients' detection of arbitrary gradients was incorrect for Python's 0-based indexingadd_gradientshandling of non-unique times was brokenmake_trapezoidincorrectly checked and reported the minimum duration for gradients specifying area and duration (also fixed in local upstream MATLAB pulseq)rotatedid not have a system parameterrotateused the incorrect channel for gradient on the second rotation axisSmall change in
add_gradientsto accept a single gradient (i.e. for cases where a variable number of gradients are added), which also allowed a minor cleanup inrotate