-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return values of make_xxx_pulse functions #47
Comments
I guess the return function executes irrespective of the |
Please let me know if pulling from the latest |
Thanks @schuenke for bearing with me. The latest commits must have fixed this for good! |
Issue is fixed now. Thanks @sravan953 ! |
Hey @sravan953, |
Hi, yes! I commit to publishing a new release by Friday (04/30). Thanks for bearing with me! |
Will this be 1.3.1post1 than? We need to submit the proofs of our paper by tomorrow and I would lile to mention the release. |
Yes |
@schuenke Hi, published! |
Thanks @sravan953 . Will test it tomorrow 👍 |
Seems to work fine. Thanks. |
Since 7542b39 the make-pulse-functions like make_sinc_pulse.py and make_gauss_pulse.py return a different number of variables as before when using
return_gz = False
.For compatibility with previous versions I suggest to return Nones for gz and gzr as it was the case before the release of v1.3.1. However, I think using the _return_gz' flag instead of the try block is a good idea and I suggest to change the return lines only. For example the make_sinc_pulse.py could be modified to:
This would also solve issue #46
Let me know if I should include this in the PRs for issue #46 and issue #48.
The text was updated successfully, but these errors were encountered: