Add eslint 7 to CI #1715
Add eslint 7 to CI #1715
Conversation
6 similar comments
| @@ -5,7 +5,7 @@ import { RuleTester } from 'eslint' | |||
| const ruleTester = new RuleTester() | |||
| , rule = require('rules/no-cycle') | |||
|
|
|||
| const error = message => ({ ruleId: 'no-cycle', message }) | |||
There was a problem hiding this comment.
should this then be test: 'no-cycle'?
There was a problem hiding this comment.
oh sorry, type. You changed a bunch of ruleID: foo to be type: foo - should they all be changed, rather than just deleting them?
There was a problem hiding this comment.
I changed some ruleId: ... to type: ... because these types are already correct, like ruleId: "ExportNameSpecifier" to type: "ExportNameSpecifier". In other places they are totally wrong , like ruleId: "no-cycle". Filling out the correct type for these cases is too much work for me.
There was a problem hiding this comment.
Can these additions made in another PR?
|
@benmosher @ljharb Any idea when this one will be released? 🤔 |
|
Ping @benmosher @ljharb |
|
@MichaelDeBoey it will be released, like every version, when I have time to do it. There's a number of outstanding PRs i'm hoping to merge first. |
|
Let me know if and how I could help getting them merged/fixed 🙂 |
The relevant breaking changes in eslint 7 are:
outputare now failed.sourceCode.getCommentsis deprecated.