[pull] main from sourcegraph:main #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran `sg wolfi update-hashes` to get this. ## Test Plan CI should find any issues this version bump could cause.
As discussed, these tags should no longer be used. With the exception of the allowPublicAccess tag, none of them hda actual enforcement in place, so in practice this doesn't change anything. The campaigns flag fallback is safe to remove, I looked through all licenses on dotcom and none that have this tag still are valid licenses anymore. They all expired well over a year ago.
Final test was successful: resetter ran on sourcegraph.com and took 1min. Logging was also helpful. So this is the production-ready version.
This PR makes more clear how cursors are meant to be used, namely, not an arbitrary string but instead using the actual values passed to the SQL prepared statement.
add localDevDenyList
* sg+wolfi: do not update digests for legacy images * update comment in oci_deps.bzl * review comments
We remove the query validation from the client, eliminating an inconsistency we had accepted for the EAP. Instead we call a new GraphQL endpoint that calls the same validation we use for job creation. The validation in the backend is just as powerful, but we don't return a slice of errors or error types. This means we don't show more than 1 error at the time, which I think this is an acceptable trade-off to keep the API small. As a consequence we don't send the error types as telemetry anymore. However, we still keep track whether an error was shown or not.
dotcom: don't lazy add repos >= 1GB && stars < 100
After we had to revert this today because a faulty version of sg downgraded postgres, trying again. ## Test plan CI found issues last time, so hoping it's gonna go green this time.
This change adds standard godoc deprecation warnings (`// Deprecated: ...`) on the _many_ legacy event-logging entry points in the backend. These are rendered prominently in VSCode (and presumably other IDEs) and will also trigger a CI failure if a deprecated function is used without a `//lint:ignore SA1019` directive ([`SA1019` is the error code for deprecated function usage](https://staticcheck.dev/docs/checks/#SA1019)). The goal is primarily to discourage new usages, and mark existing usages that will need to be migrated, so this PR adds `//lint:ignore SA1019` docstrings at all existing callsites. I've also added a deprecation warning on the `logEvent` and `logEvents` mutations in the GraphQL schema. Closes https://github.com/sourcegraph/sourcegraph/issues/56973 - in the web app and Cody repo, we already use JSDoc deprecation notices.
…58778) The build can be finished and have failing jobs but a late job can come in and make the build "not be finished", which is a problem since we don't get a notification for the late job finishing, which leads to the job perpetually being in in-progress. We do not count in-progress jobs anymore because this can lead to invalid build states even though the build is finished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )