analyze: borrowck performance improvements #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fw-immunant
approved these changes
Aug 7, 2024
kkysen
reviewed
Aug 8, 2024
| @@ -383,7 +384,7 @@ fn run_polonius<'tcx>( | |||
| fn try_load_cached_output(facts_hash: &str) -> Option<Output> { | |||
| let path = format!("polonius_cache/{}.output", facts_hash); | |||
|
|
|||
| let f = File::open(&path).ok()?; | |||
| let f = BufReader::new(File::open(&path).ok()?); | |||
There was a problem hiding this comment.
Is it faster to just read it all at once? Sometimes I've found that to be faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some easy borrowck/Polonius performance improvements while investigating a performance regression on a development branch.
BufReader/BufWriterwhen loading/saving from thepolonius_cache. Otherwisebincodereads/writes each 8-byte field individually.inspect/FUNC/*.factsunless requested withC2RUST_ANALYZE_DUMP_POLONIUS_FACTS=1. This takes a nontrivial amount of time for big functions and is only needed when debugging certain borrowck issues.Improvements compared to master (all measurements taken on the second run, after populating
polonius_cache/):cargo test algo_md5: 25s -> 4.6scargo test --release algo_md5: 16s -> 2.1s