Initialize fork of a library and changes for compatibility with php52 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariettiell
reviewed
Mar 27, 2017
examples/vanilla/index.php
Outdated
| (new \Raven_Client(SENTRY_DSN)) | ||
| ->setAppPath(__DIR__) | ||
| $sentryClient = new Raven_Client(SENTRY_DSN); | ||
| $__DIR__ = version_compare(PHP_VERSION, '5.3.0', '>=') ? __DIR__ : dirname(__FILE__); |
There was a problem hiding this comment.
maybe, because dirname is defined in all php versions, you can use it always, without checking the PHP_VERSION const
test/Raven/Tests/ClientTest.php
Outdated
|
|
||
| class Helper_Php52 | ||
| { | ||
| public static $__DIR__ = null; |
There was a problem hiding this comment.
better if not public, you also have the getter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize fork of a official library
changes for compatibility with php52