-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxyReq.removeHeader throws an error on tab load #143
Comments
Hi @zjpersc, I searched for the error and found this issue related to our proxying plugin:chimurai/http-proxy-middleware#343 http-party/node-http-proxy#1287 I have to find a way to reproduce locally the same error. Could you let me know if the plugin works if you catch the error? |
@antoniomuso I will say that I validated adding the 'proxyTimeout: 20000' to the httpProxyMiddleware options works for me. If you would like I can submit that as a PR to this project, but it is just one line here: After Line 35: Add: |
@antoniomuso Catching the error w/o doing the proxyTimeout works as well. My code:
|
Hi, catching seems to me a good solution, we can also add a custom timeout as optional parameter in plugin configuration. |
…dleware Signed-off-by: zjpersc <[email protected]>
Refs: immobiliare#143 Signed-off-by: zjpersc <[email protected]>
Refs: immobiliare#143 Signed-off-by: zjpersc <[email protected]>
Refs: immobiliare#143 Signed-off-by: zjpersc <[email protected]> fix: catching the error from http-proxy-middleware Refs: immobiliare#143 Signed-off-by: zjpersc <[email protected]>
Refs: immobiliare#143 Signed-off-by: zjpersc <[email protected]>
The catch didn't fix the problem, I just get 401 on every request, I think that something similar to what backstage did with the problem should be implemented: https://github.com/backstage/backstage/blob/f1c2ff2cdb01fa8c7d02e4d224ae5513e4a6b542/plugins/proxy-backend/src/service/router.ts#L144 |
LGTM! Good catch @fmenesesg |
closed by #184 |
Please see my comment 9a30295#commitcomment-117894397 |
Running Backstage v1.12.0 and v5.0.0 of the plugin.
When loading the tab associated with the plugin's content, the following error is thrown:
I have been able to mitigate the error by commenting out the following code:
I assume the code is necessary, so I don't view that as likely a long term fix.
The text was updated successfully, but these errors were encountered: