-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify gitlab instances by unique id #118
Labels
enhancement
New feature or request
Comments
Hi @manuelstein, if you give the time to Backstage, it automatically reprocesses the entities with the correct instance annotation (I tested it, and it does it). However, your proposal LGTM, so you are welcome if you want to implement it. |
5 tasks
manuelstein
added a commit
to manuelstein/backstage-plugin-gitlab
that referenced
this issue
Mar 8, 2023
gitlab-backend router and processor no longer use a generated index number to identify the instance but the hostname of the gitlab instance closes immobiliare#118 Signed-off-by: Manuel Stein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I've noticed the multiple GitLab instance support numbers instances as they appear in the GitLab integration config.
AFAIK, the processor runs on catalog entries once they are ingested, so when the GitLab integration array changes (e.g. a new GitLab instance is added), there would be a mismatch on catalog entries that were processed before the change.
I'm suggesting to identify the GitLab instance by a unique ID. I used to maintain an implementation based on the loblaw version that was using the GitLab instance's hostname (GitLab config
host
field). Btw, thanks for taking over and actively driving the development of this plugin.I'm implementing my suggested change for our internal use and would happily contribute upstream.
wdyt?
The text was updated successfully, but these errors were encountered: