refactor: removed not needed code

immobiliare · Jun 12, 2023 · b8eb7ff · b8eb7ff
1 parent 8e644e3
commit b8eb7ff
Show file tree

Hide file tree

Showing 8 changed files with 26 additions and 42 deletions.
diff --git a/packages/gitlab/src/components/widgets/IssuesTable/IssuesTable.tsx b/packages/gitlab/src/components/widgets/IssuesTable/IssuesTable.tsx
@@ -77,19 +77,14 @@ export const IssuesTable = ({}) => {
  if (!projectDetails)
  throw new Error('wrong project_slug or project_id');
 
- const projectId = project_id || projectDetails.id;
+ const summary = await GitlabCIAPI.getIssuesSummary(projectDetails.id);
 
- const [summary, projectName] = await Promise.all([
- GitlabCIAPI.getIssuesSummary(projectId),
- GitlabCIAPI.getProjectName(projectId),
- ]);
-
- if (!summary || !projectName) {
- throw new Error('project name or gitlab issues are undefined!');
+ if (!summary) {
+ throw new Error('gitlab issues is undefined!');
  }
  const renderData = {
  data: summary,
- projectName,
+ projectName: projectDetails.name,
  };
 
  return renderData;

diff --git a/packages/gitlab/src/components/widgets/LanguagesCard/LanguagesCard.tsx b/packages/gitlab/src/components/widgets/LanguagesCard/LanguagesCard.tsx
@@ -64,8 +64,9 @@ export const LanguagesCard = ({}) => {
  if (!projectDetails)
  throw new Error('wrong project_slug or project_id');
 
- const projectId = project_id || projectDetails.id;
- const summary = await GitlabCIAPI.getLanguagesSummary(projectId);
+ const summary = await GitlabCIAPI.getLanguagesSummary(
+ projectDetails.id
+ );
  if (!summary) throw new Error('Languages summary is not defined!');
 
  return summary;

diff --git a/packages/gitlab/src/components/widgets/MergeRequestStats/MergeRequestStats.tsx b/packages/gitlab/src/components/widgets/MergeRequestStats/MergeRequestStats.tsx
@@ -92,9 +92,12 @@ const MergeRequestStats = (props: Props) => {
  );
  if (!projectDetails)
  throw new Error('wrong project_slug or project_id');
- const projectId = project_id || projectDetails.id;
+
  const mergeRequestStatusData =
- await GitlabCIAPI.getMergeRequestsStatusSummary(projectId, count);
+ await GitlabCIAPI.getMergeRequestsStatusSummary(
+ projectDetails.id,
+ count
+ );
 
  if (!mergeRequestStatusData)
  throw new Error('getMergeRequestsStatusSummary error');

diff --git a/packages/gitlab/src/components/widgets/MergeRequestsTable/MergeRequestsTable.tsx b/packages/gitlab/src/components/widgets/MergeRequestsTable/MergeRequestsTable.tsx
@@ -76,19 +76,13 @@ export const MergeRequestsTable = ({}) => {
  if (!projectDetails)
  throw new Error('wrong project_slug or project_id');
 
- const projectId = project_id || projectDetails.id;
-
- const [summary, projectName] = await Promise.all([
- GitlabCIAPI.getMergeRequestsSummary(projectId),
- GitlabCIAPI.getProjectName(projectId),
- ]);
+ const summary = await GitlabCIAPI.getMergeRequestsSummary(
+ projectDetails.id
+ );
 
- if (!summary || !projectName)
- throw new Error(
- 'Merge request summary or project_name are undefined!'
- );
+ if (!summary) throw new Error('Merge request summary is undefined!');
 
- return { data: summary, projectName };
+ return { data: summary, projectName: projectDetails.name };
  }, []);
 
  if (loading) {

diff --git a/packages/gitlab/src/components/widgets/PeopleCard/PeopleCard.tsx b/packages/gitlab/src/components/widgets/PeopleCard/PeopleCard.tsx
@@ -54,17 +54,15 @@ export const PeopleCard = ({}) => {
  if (!projectDetails)
  throw new Error('wrong project_slug or project_id');
 
- const projectId = project_id || projectDetails.id;
-
  const contributorData = await GitlabCIAPI.getContributorsSummary(
- projectId
+ projectDetails.id
  );
 
  // CODE OWNERS
  let codeOwners: PeopleCardEntityData[] | undefined = [];
  try {
  codeOwners = await GitlabCIAPI.getCodeOwners(
- projectId,
+ projectDetails.id,
  projectDetails?.default_branch,
  codeowners_path
  );

diff --git a/packages/gitlab/src/components/widgets/PipelinesTable/PipelinesTable.tsx b/packages/gitlab/src/components/widgets/PipelinesTable/PipelinesTable.tsx
@@ -71,18 +71,11 @@ export const PipelinesTable = ({}) => {
  );
  if (!projectDetails)
  throw new Error('wrong project_slug or project_id');
- const projectId = project_id || projectDetails.id;
 
- const [summary, projectName] = await Promise.all([
- GitlabCIAPI.getPipelineSummary(projectId),
- GitlabCIAPI.getProjectName(projectId),
- ]);
+ const summary = await GitlabCIAPI.getPipelineSummary(projectDetails.id);
 
- if (!summary || !projectName)
- throw new Error(
- 'Merge request summary or project_name are undefined!'
- );
- return { summary, projectName };
+ if (!summary) throw new Error('Merge request summary is undefined!');
+ return { summary, projectName: projectDetails.name };
  }, []);
 
  if (loading) {

diff --git a/packages/gitlab/src/components/widgets/ReadmeCard/ReadmeCard.tsx b/packages/gitlab/src/components/widgets/ReadmeCard/ReadmeCard.tsx
@@ -46,11 +46,10 @@ export const ReadmeCard = ({}) => {
  if (!projectDetails)
  throw new Error('wrong project_slug or project_id');
 
- const projectId = project_id || projectDetails.id;
  let readmeData: string | undefined = undefined;
  try {
  readmeData = await GitlabCIAPI.getReadme(
- projectId,
+ projectDetails.id,
  projectDetails.default_branch,
  readme_path
  );

diff --git a/packages/gitlab/src/components/widgets/ReleasesCard/ReleasesCard.tsx b/packages/gitlab/src/components/widgets/ReleasesCard/ReleasesCard.tsx
@@ -110,8 +110,9 @@ export const ReleasesCard = (props: ReleasesCardProps) => {
  if (!projectDetails)
  throw new Error('wrong project_slug or project_id');
 
- const projectId = project_id || projectDetails.id;
- const releaseData = await GitlabCIAPI.getReleasesSummary(projectId);
+ const releaseData = await GitlabCIAPI.getReleasesSummary(
+ projectDetails.id
+ );
 
  if (!releaseData) throw new Error('Release data are undefined!');