fix: no data error

immobiliare · Aug 29, 2023 · b44eb1d · b44eb1d
1 parent e1c4b8b
commit b44eb1d
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 12 deletions.
diff --git a/packages/gitlab/src/api/GitlabCIClient.ts b/packages/gitlab/src/api/GitlabCIClient.ts
@@ -112,9 +112,7 @@ export class GitlabCIClient implements GitlabCIApi {
  return undefined;
  }
 
- protected async callGraphQLApi<T>(
- query: GraphQLQuery
- ): Promise<T | undefined> {
+ protected callGraphQLApi<T>(query: GraphQLQuery): Promise<T | undefined> {
  const options = {
  method: 'POST',
  headers: {
@@ -294,7 +292,7 @@ export class GitlabCIClient implements GitlabCIApi {
  ): Promise<GitlabProjectCoverageResponse | undefined> {
  if (!projectSlug) return undefined;
 
- return await this.callGraphQLApi<GitlabProjectCoverageResponse>({
+ return this.callGraphQLApi<GitlabProjectCoverageResponse>({
  variables: {
  projectSlug,
  projectDefaultBranch,

diff --git a/packages/gitlab/src/components/GitlabCI/GitlabCI.tsx b/packages/gitlab/src/components/GitlabCI/GitlabCI.tsx
@@ -10,6 +10,7 @@ import {
  PipelinesTable,
  ReleasesCard,
  ReleasesCardProps,
+ CoverageCard,
 } from '../widgets';
 
 export type GitlabPageProps = {
@@ -41,6 +42,9 @@ export const GitlabCI = (props: GitlabPageProps) => (
  <Grid item md={12}>
  <IssuesTable />
  </Grid>
+ <Grid item md={12}>
+ <CoverageCard />
+ </Grid>
  </Grid>
  </Content>
  </Page>

diff --git a/packages/gitlab/src/components/widgets/CoverageCard/CoverageCard.tsx b/packages/gitlab/src/components/widgets/CoverageCard/CoverageCard.tsx
@@ -99,19 +99,26 @@ const CoverageCard = (props: Props) => {
  >
  <Box position="relative">
  <div className={classes.lineChartContainer}>
- <LineChart
- xAxis={[{ scaleType: 'point', dataKey: 'x' }]}
- series={[{ dataKey: 'y' }]}
- dataset={dataset}
- height={300}
- margin={{ bottom: 90, top: 20, left: 40, right: 20 }}
- />
+ {dataset.length > 0 && (
+ <LineChart
+ xAxis={[{ scaleType: 'point', dataKey: 'x' }]}
+ series={[{ dataKey: 'y' }]}
+ dataset={dataset}
+ height={300}
+ margin={{
+ bottom: 90,
+ top: 20,
+ left: 40,
+ right: 20,
+ }}
+ />
+ )}
  </div>
 
  <div>
  {' '}
  <b>Last Coverage: </b>
- {!!value.coverageDetails
+ {dataset.length > 0
  ? `${value.coverageDetails[0].coverage}%`
  : 'No data'}
  </div>