Skip to content

Commit

Permalink
fix: allow extensions
Browse files Browse the repository at this point in the history
  • Loading branch information
antoniomuso committed Jan 20, 2023
1 parent e788b01 commit 38a6fc1
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 5 deletions.
15 changes: 13 additions & 2 deletions packages/gitlab-backend/package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
{
"name": "@immobiliarelabs/backstage-plugin-gitlab-backend",
"version": "0.1.0",
"main": "dist/index.esm.js",
"main": "dist/index.cjs.js",
"types": "dist/index.d.ts",
"license": "Apache-2.0",
"private": true,
"publishConfig": {
"access": "public",
"main": "dist/index.cjs.js",
Expand All @@ -13,6 +12,18 @@
"backstage": {
"role": "backend-plugin"
},
"repository": {
"type": "git",
"url": "https://github.com/immobiliare/backstage-plugin-gitlab"
},
"keywords": [
"backstage",
"gitlab",
"ci/cd",
"immobiliare",
"immobiliarelabs",
"backend"
],
"scripts": {
"start": "backstage-cli package start",
"types": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/gitlab/dev/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ createDevApp()
codeOwnersPath: configApi.getOptionalString(
'gitlab.defaultCodeOwnersPath'
),
}).build(0);
}).build('0');

// Here we mock the client requests to GitLab
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
Expand Down
4 changes: 2 additions & 2 deletions packages/gitlab/src/api/GitlabCIClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class GitlabCIClient implements GitlabCIApi {
codeOwnersPath: string;
gitlabInstance: string;

private constructor({
constructor({
discoveryApi,
baseUrl = 'https://gitlab.com/',
codeOwnersPath,
Expand Down Expand Up @@ -51,7 +51,7 @@ export class GitlabCIClient implements GitlabCIApi {
}) {
return {
build: (gitlabInstance: string) =>
new GitlabCIClient({
new this({
discoveryApi,
baseUrl,
codeOwnersPath,
Expand Down

0 comments on commit 38a6fc1

Please sign in to comment.