-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread Safety Issue accessing to HTTPDataLoader (#2) #48
Comments
We made some improvements with #45 but this improves the safety of the loader's dictionary in a multi-threading environment. Thank you very much. |
malcommac
added a commit
that referenced
this issue
May 24, 2022
fix #48: fixes data access issue with multithread
Thanks for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Summary
We have seen intermittent crashes in
HTTPDataLoader.fetch
, while writing a response to the dataLoadersMap dictionary. A cursory inspection of the code inHTTPDataLoader
makes it look like this dictionary is not protected by atomic access, but it is being accessed (both read from and written to) from multiple threads. The access is inside an operation added to the session's delegate queue, but this queue is concurrent. We believe this may be why we are seeing intermittent crashes in this area.The text was updated successfully, but these errors were encountered: