Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cURLDescription also for HTTPResponse #18

Closed
malcommac opened this issue Mar 12, 2022 · 0 comments
Closed

Added cURLDescription also for HTTPResponse #18

malcommac opened this issue Mar 12, 2022 · 0 comments
Assignees
@malcommac
Labels
enhancement New feature or request
Milestone
1.2.0

Comments

@malcommac
Copy link
Collaborator

Feature Request

cURLDescription() function should be available also in HTTPResponse instances in order to print the executed statements for the original request without passing explicitly the client.

Q A
New Feature yes
RFC no
BC Break no

Note

Due to #17 we should move the cURLDescription() function for HTTPRequest to async because the serialization of data is now made on another thread.
@malcommac malcommac added this to the 1.2.0 milestone Mar 12, 2022
@malcommac malcommac added the enhancement New feature or request label Mar 12, 2022
@malcommac malcommac self-assigned this Mar 12, 2022
malcommac added a commit that referenced this issue Mar 12, 2022
@malcommac
new #18: Making the cURLDescription available for HTTPResponse. for H…
d5e3178 
…TTPRequest is now async.
malcommac added a commit that referenced this issue Mar 12, 2022
@malcommac
setHTTPBody() is now async due to #18
7878733
malcommac added a commit that referenced this issue Mar 12, 2022
@malcommac
new #18: Added actor for JSONSerializable and JSONEncodable
9b0074e
malcommac added a commit that referenced this issue Mar 12, 2022
@malcommac
new #18: deprecated urlParameters() to formURLEncodedBody()
2758a60
malcommac added a commit that referenced this issue Mar 12, 2022
@malcommac
new #18: updated documentation to formURLEncoded
1f7dc22
malcommac added a commit that referenced this issue Mar 12, 2022
@malcommac
new #18: fixed tests due to new async/actor serialization of data
29ba2bf
malcommac added a commit that referenced this issue Mar 12, 2022
@malcommac
new #18: completed actor serialization for data
c6b7255
@malcommac malcommac mentioned this issue Mar 12, 2022
Merged
@malcommac malcommac changed the title cURLDescription for HTTPResponse Added cURLDescription also for HTTPResponse Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malcommac malcommac

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@malcommac