Fixing License issue in MVVM pattern

[jinishavora]

Have added LGPL and GPL license txt files in root dir.
Have updated LICENSE.md file with added GPL license, should I add LGPL License as well, I thought they can be used interchangeably, but I can be wrong???
Have updated the parent pom such that it will update all the source files including updating all src files within the modules with the license as mentioned in LICENSE.md
@iluwatar @ohbus Please review my above comments and the code changes and let me know what are your thoughts.

[iluwatar]

Relates to issue #1690

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[jinishavora]

@ohbus @iluwatar Please review the changes and let me know if its ok ?

[ohbus]

@ohbus @iluwatar Please review the changes and let me know if its ok ?

Let me check.

[ohbus]

Why are we adding the GPL text?

Could out just point it back to me. I just lost track if we have already discussed it earlier somewhere else.

[jinishavora]

Why are we adding the GPL text?

Could out just point it back to me. I just lost track if we have already discussed it earlier somewhere else.

I added it with lgpl, not sure if we needed both, should I get rid of the gpl one?

[ohbus]

Why are we adding the GPL text?
Could out just point it back to me. I just lost track if we have already discussed it earlier somewhere else.

I added it with lgpl, not sure if we needed both, should I get rid of the gpl one?

I believe we should discard GPL text

[jinishavora]

@ohbus, check latest changes and let me know

[ohbus]

Thanks for the changes and updates!

[jinishavora]

@ohbus @iluwatar I hope this one is done? let me know if I have missed something..

[iluwatar]

A couple of things:

• We need to add the GPL text as well because https://www.gnu.org/licenses/lgpl-3.0.html requires it (see chapter 4, combined works)
• There are conflicts preventing the merge

[jinishavora]

A couple of things:

• We need to add the GPL text as well because https://www.gnu.org/licenses/lgpl-3.0.html requires it (see chapter 4, combined works)
• There are conflicts preventing the merge

@iluwatar I had the gpl text, @ohbus suggested I remove it, can you please confirm if the file I removed is the one we need back or do we need something else?

[iluwatar]

@jinishavora yes, looks correct to me. Please restore it and we can merge.

[ohbus]

A couple of things:

• We need to add the GPL text as well because https://www.gnu.org/licenses/lgpl-3.0.html requires it (see chapter 4, combined works)
• There are conflicts preventing the merge

@jinishavora yes, looks correct to me. Please restore it and we can merge.

Thank you so much @iluwatar for the suggestions. Really helped a lot.

[ohbus]

A couple of things:

• We need to add the GPL text as well because https://www.gnu.org/licenses/lgpl-3.0.html requires it (see chapter 4, combined works)
• There are conflicts preventing the merge

@iluwatar I had the gpl text, @ohbus suggested I remove it, can you please confirm if the file I removed is the one we need back or do we need something else?

Really sorry for the trouble @jinishavora, I have overlooked it.

Please make the necessary amendments to the PR to get it accepted.

[jinishavora]

A couple of things:

• We need to add the GPL text as well because https://www.gnu.org/licenses/lgpl-3.0.html requires it (see chapter 4, combined works)
• There are conflicts preventing the merge

@iluwatar I had the gpl text, @ohbus suggested I remove it, can you please confirm if the file I removed is the one we need back or do we need something else?

Really sorry for the trouble @jinishavora, I have overlooked it.

Please make the necessary amendments to the PR to get it accepted.

No worries @ohbus, file committed, please review.

[jinishavora]

@jinishavora yes, looks correct to me. Please restore it and we can merge.

@iluwatar done, please review.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[ohbus]

LGTM

[iluwatar]

Thank you for handling this issue @jinishavora, it wasn't the easiest to work with. Your contribution is much appreciated!

[jinishavora]

Thank you for handling this issue @jinishavora, it wasn't the easiest to work with. Your contribution is much appreciated!

Thanks @iluwatar! Appreciate your kind words.