-
-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing License issue in MVVM pattern #1701
Conversation
Relates to issue #1690 |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding the GPL text?
Could out just point it back to me. I just lost track if we have already discussed it earlier somewhere else.
I added it with lgpl, not sure if we needed both, should I get rid of the gpl one? |
I believe we should discard GPL text |
@ohbus, check latest changes and let me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes and updates!
A couple of things:
|
@iluwatar I had the gpl text, @ohbus suggested I remove it, can you please confirm if the file I removed is the one we need back or do we need something else? |
@jinishavora yes, looks correct to me. Please restore it and we can merge. |
Thank you so much @iluwatar for the suggestions. Really helped a lot. |
Really sorry for the trouble @jinishavora, I have overlooked it. Please make the necessary amendments to the PR to get it accepted. |
No worries @ohbus, file committed, please review. |
@iluwatar done, please review. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for handling this issue @jinishavora, it wasn't the easiest to work with. Your contribution is much appreciated! |
Thanks @iluwatar! Appreciate your kind words. |
* Fixing License issue in MVVM pattern * Updating LICENSE.md * Updating pom.xml * License header update to MVVM module only. * Updating pom and removing gpl txt * Adding gpl txt file Co-authored-by: Jinisha <[email protected]>
Have added LGPL and GPL license txt files in root dir.
Have updated LICENSE.md file with added GPL license, should I add LGPL License as well, I thought they can be used interchangeably, but I can be wrong???
Have updated the parent pom such that it will update all the source files including updating all src files within the modules with the license as mentioned in LICENSE.md
@iluwatar @ohbus Please review my above comments and the code changes and let me know what are your thoughts.