add query param for chosen school on programs route #7935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
requested changes
Jul 5, 2024
| @@ -41,8 +40,8 @@ export default class ProgramRootComponent extends Component { | |||
| } | |||
|
|
|||
| get bestSelectedSchool() { | |||
| if (this.selectedSchoolId) { | |||
| return findById(this.args.schools.slice(), this.selectedSchoolId); | |||
There was a problem hiding this comment.
This slice() used to be needed as ember-data returned a thing that wasn't quite an array, however those days are gone and this can go away too and should do the same thing. Unless I'm wrong. Which isn't impossible.
This seems like a great idea. Just as an aside, I don't see any kind of test for this kind of thing in the main Courses test file, but maybe it's located somewhere else. |
jrjohnson
requested changes
Jul 8, 2024
|
@jrjohnson Changes requested exist in the same file outside of the PR, so will follow up with a PR after this that fixes that for all of them. |
jrjohnson
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#3457