Skip to content

Commit

Permalink
build(dev.Dockerfile): optimize dev.Dockerfile
Browse files Browse the repository at this point in the history
  • Loading branch information
iknowright committed Sep 25, 2023
1 parent c698ae7 commit eb9bdd1
Showing 1 changed file with 19 additions and 27 deletions.
46 changes: 19 additions & 27 deletions dev.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,44 +1,36 @@
FROM python:3.6-slim-buster
# [Node Stage to get node_modolues and node dependencies]
FROM node:8.16.0-buster-slim as node_stage

COPY ./yarn.lock yarn.lock
COPY ./package.json package.json

RUN npm install -g yarn
RUN yarn install --dev --frozen-lockfile

# [Python Stage for Django web server]
FROM python:3.6-slim-buster as python_stage

ENV PYTHONUNBUFFERED 1
WORKDIR /app

ENV BASE_DIR /usr/local
COPY --from=node_stage /node_modules ./node_modules
COPY --from=node_stage /usr/local/bin/node /usr/local/bin/node

ENV NVM_INSTALLER_URL https://raw.githubusercontent.com/creationix/nvm/v0.33.0/install.sh
ENV NVM_DIR $BASE_DIR/nvm
ENV YARN_VERSION 1.15.2-1
ENV NODE_VERSION 8.16.0
ENV PYTHONUNBUFFERED 1
ENV BASE_DIR /usr/local

# make nodejs and yarn accessible and executable globally
ENV PATH $NVM_DIR/versions/node/v$NODE_VERSION/bin:$PATH
# make node accessible and executable globally
ENV PATH /usr/local/bin:$PATH

# Infrastructure tools
# gettext is used for django to compile .po to .mo files.
RUN apt-get update
RUN apt-get install apt-utils -y
RUN apt-get update
RUN apt-get install gettext python3-pip -y

# Install Node and Yarn from upstream
RUN curl -o- $NVM_INSTALLER_URL | bash \
&& . $NVM_DIR/nvm.sh \
&& nvm install $NODE_VERSION \
&& nvm alias default $NODE_VERSION \
&& nvm use default \
&& nvm --version \
&& npm install -g yarn \
&& yarn --version
RUN apt-get install gettext gcc -y

# Only copy and install requirements to improve caching between builds
# Install Python dependencies
COPY ./requirements ./requirements
RUN pip3 install -r ./requirements/dev.txt

# # Install Javascript dependencies
COPY ./package.json ./package.json
COPY ./yarn.lock ./yarn.lock
RUN yarn install --dev --frozen-lockfile

# for entry point
COPY ./docker-entrypoint.sh /docker-entrypoint.sh
RUN chmod +x /docker-entrypoint.sh

0 comments on commit eb9bdd1

Please sign in to comment.