Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes: #79

Closed
wants to merge 3 commits into from
Closed

Changes: #79

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2016

  1. Add a switch in layout "KeyMapCreator" for enable nfc reader mode.
  2. Add switch name at line 189 in strings.xml.
  3. Add codes from line 197 to line 220 in KeyMapCreator.java.
  4. Add users-sdk minSdkVersion 19.
    Reasons:
    Some phones (such as Huawei Honor 7 or Huawei Honor 4C) disable nfc intent through changed the mask in file /system/etc/libnfc-brcm_PLK.conf. So that application cannot receive any nfc intent from system. But if enable nfc reader mode, everything will be fine!

Hope author update this application to Google Play soon!

1. Add a switch in layout "KeyMapCreator" for enable nfc reader mode.
2. Add switch name at line 189 in strings.xml.
3. Add codes from line 197 to line 220 in KeyMapCreator.java.
4. Add users-sdk minSdkVersion 19.
@ikarus23
Copy link
Owner

Hi. First of all: Thanks for contributing. I will look into this as soon as possible.

Regarding 4.:
I don't think I will raise the minSdkVersion to 19. There are over 7000 active installations on devices with SDK < 19. I don't want to lose them. At least not now.

@ghost
Copy link
Author

ghost commented Jan 26, 2016

Thank you for replying to me. This is the first time I submitted the code in the GitHub.There are some deviations in the description, please forgive me.

Regarding 4, I raised the minSdkVersion to 19 because the switch need minSdkVersion 19. You can change another way(for example: CheckBox) to implement that without raise minSdkVersion to 19.

The "Reasons: Some phones ..." which I wrote is for the reason why I change the code, not just for the Fourth point. You can use any other SDK version if you implement NFC reader mode.

Thank you very much.

2.Set a shared preference to save the status of enable reader mode so that software can enable or disable reader mode automatically.
3.Remove the requirement of minSDKVersion.
@ghost
Copy link
Author

ghost commented Mar 8, 2016

I change the code for minSDKVersion back to normal

Copy link

@lavr1986uxa lavr1986uxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mutch tks

@lavr1986uxa
Copy link

Mifare Classic Tool/app/src/main/java/de/syss/MifareClassicTool/Activities/KeyMapCreator.java

@sesam
Copy link

sesam commented Sep 4, 2018

ping @ghost or someone else looking into the merge conflict?

@ikarus23
Copy link
Owner

ikarus23 commented Sep 5, 2018

Not sure if I'm comfortable with merging this. Not even sure we need the reader mode of Android since we use the foreground dispatch system.

@ikarus23
Copy link
Owner

As I don't see why MCT need these changes I will close this PR for now.

@ikarus23 ikarus23 closed this Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants