Optimize much #363
Optimize much #363
Conversation
Goooler
commented
Dec 26, 2021
Goooler
commented
- Update dependencies & Replace jcenter.
- Add .gitattributes & .editorconfig.
- Code cleanups.
- Add CI for building.
|
Thank you! I will have a closer look and give some feedback in the respective commit. A lot of my feedback will probably be questions, because I'm no Android developer guru like you ;) |
|
No problem. |
There was a problem hiding this comment.
I have no experience with github CI. I guess it will work since you have tested it :)
There is a new line missing at the end of the file.
Edit: Oh, it shows up here. I hoped it would be pinned to a specific commit. (in this case f5991cb)
.github/workflows/ci.yml
Outdated
| key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle/wrapper/gradle-wrapper.properties', '**/buildSrc/src/main/kotlin/**.kt') }} | ||
| - name: Build | ||
| working-directory: ${{ env.PROJECT_PATH }} | ||
| run: ./gradlew --parallel assembleRelease |
There was a problem hiding this comment.
New line is missing at the end of the file.
| // MIFARE Plus EV1 2K/4K SL1 | ||
| return -1; | ||
| } | ||
| return -1; |
There was a problem hiding this comment.
I did this to make the code more readable and closer to the datasheet linked in an above comment.
I don't like the optimized version. It is not readable.
| @@ -4,7 +4,6 @@ plugins { | |||
|
|
|||
| android { | |||
| compileSdkVersion 31 | |||
| buildToolsVersion '31.0.0' | |||
There was a problem hiding this comment.
Is safe to remove this? What build tools version will be used when it's not declared?
| @@ -1,79 +1,129 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Why replace it with just /bin/sh? The old format made more sense to me.
Did you do the big grade update yourself or is there an automatic tool for it?
There was a problem hiding this comment.
Generate gradle wrapper by running ./gradlew wrapper.
|
CI passed on my forked repo.
|
|
There was a big jar file at |
|
Well, I guess it should. At least it was there before. Just got bigger :) |
|
Yeah, you can learn the gradle project structure. |
