Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies & optimize gradle #348

Merged
merged 1 commit into from
May 24, 2021
Merged

Update dependencies & optimize gradle #348

merged 1 commit into from
May 24, 2021

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented May 24, 2021

No description provided.

@ikarus23
Copy link
Owner

Thank you very much!. I think I have to take your word for it. I have not clue about gradle optimizations. Not even sure if lines like

    compileOptions {
            sourceCompatibility 1.8
            targetCompatibility 1.8
    }

were required.

I will merge it anyways. It looks like you know what you are doing :)

@ikarus23 ikarus23 merged commit 96c5d27 into ikarus23:master May 24, 2021
@Goooler Goooler deleted the gradle branch May 24, 2021 10:44
@Goooler
Copy link
Contributor Author

Goooler commented May 24, 2021

Thank you very much!. I think I have to take your word for it. I have not clue about gradle optimizations. Not even sure if lines like

    compileOptions {
            sourceCompatibility 1.8
            targetCompatibility 1.8
    }

were required.

I will merge it anyways. It looks like you know what you are doing :)

Yeah, AGP 4.2.1 with default java version of 1.8, no need to declare them.

@Goooler
Copy link
Contributor Author

Goooler commented May 24, 2021

And suggest you add a github action for CI, verify the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants