Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for new version. #322

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Translations for new version. #322

merged 2 commits into from
Nov 6, 2020

Conversation

nkh0472
Copy link
Contributor

@nkh0472 nkh0472 commented Nov 6, 2020

No description provided.

@nkh0472
Copy link
Contributor Author

nkh0472 commented Nov 6, 2020

There are some little question.

For
<string name="text_block_0_generated">Block 0 generated</string>
Does it mean "the data of block 0 has been generated" or "the generated data of block 0"?
I changed the translation from the latter to the former.

For
<string name="action_generic_converter">Generic Type Converter</string>
Does "Generic Type Converter" is the converter to change the data from HEX/BIN/… to each other?

For
<string name="action_cyber_chef">Cyber Chef</string>
Is it https://github.com/gchq/CyberChef or something like that, so I can simply call it "Cyber Chef" without translation?

@ikarus23
Copy link
Owner

ikarus23 commented Nov 6, 2020

Thanks again for doing all this!

Does it mean "the data of block 0 has been generated" or "the generated data of block 0"?
I changed the translation from the latter to the former.

The first one!

Does "Generic Type Converter" is the converter to change the data from HEX/BIN/… to each other?

Yes, this is just a simple/generic/common converter for data types or data representations. Like HEX/ASCII/INT/UINT/INT16/etc.

Is it https://github.com/gchq/CyberChef or something like that, so I can simply call it "Cyber Chef" without translation?

Yes, Cybe Chef is a "product" name. So there is no need to translate it.

@nkh0472
Copy link
Contributor Author

nkh0472 commented Nov 6, 2020

Now it's finished.

@ikarus23 ikarus23 merged commit 690cbf5 into ikarus23:master Nov 6, 2020
@ikarus23
Copy link
Owner

ikarus23 commented Nov 6, 2020

Thank you!

@nkh0472 nkh0472 deleted the patch-2 branch November 7, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants