-
-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new translating & reorder strings. #314
Conversation
First, all of the English strings from /app/src/main/res/values/strings.xml has been translated. The original file contains 291 strings, and I added & translated new 93 strings from the English file, and improved some translating too. Besides, I reordered the strings to keep consistency with English strings.xml, which could be very helpful to stay the latest for further updates. However, I don't have any experience with compelling Android apps, so the above changes is never been tested. It's very important to test this new translate file, to avoid full screen of R#%#&#&*)@(IDHDBKJB. ^^
New strings from the English file are listed as below: title_activity_clone_uid |
Thank you for contributing and thank you for reorganizing everything! It's hard for me to validate, if everything is displayed the correct way. However, it is not hard for me to build a test version ;). You can download it from here. Please install it and validate if everything looks good (or good enough). |
The test version showed exactly what was expected. However, I found that the old translation's quality is still very poor, and every sentence can see the traces of machine translation. I will fully rewrite them tomorrow. |
Wow, that is great! Thank you so much for doing this. |
Re-translate strings.
Main work of this has been completed, and I plan to check if any symbols cannot be displayed. (I saw some Unicode in the strings such as •, I’m not sure every symbol I write could be displayed. For example, I use CUID/FUID instead of magic card (gen 2) because the former is used in China, here, the symbol "/" might be a problem. Besides, I don't quite understand the meaning of some strings. Can you explain them a little bit?
|
Minor changes.
Thank you for the update!
Be careful with that. There are a lot of different CUID tags out there. But only gen2 tags work with this app. Other CUID tags do not work. So "gen 2" is very important (see https://github.com/ikarus23/MifareClassicTool#general-information (point nr. 4) and https://github.com/RfidResearchGroup/proxmark3/blob/master/doc/magic_cards_notes.md (section about MIFARE Classic)).
I hope this helps. |
Updated version for testing: http:https://tests.icaria.de/MifareClassicTool-3.1.2-test2.apk |
Those descriptions help me a lot!
Should I translate it to "position" or "the name of value (such as abc or xyz)"? I translate it into position for now. There is no problem caused by symbols in MifareClassicTool-3.1.2-test2.apk. And I've further corrected other inappropriate translations. |
Thank you for your patient reply to me all the time! So far, everything is displayed correctly. I don't think it is necessary to compile the third test version to confirm whether the display is ok. And I'll edit this xml file if there is any translating problem. Just out of curiosity, how long does it take to compile this app on your computer? |
Are you finished translating? If so, I will merge it. |
It's OK to merge. The meaning as "the act of putting something in a certain place" or "the location of someone or something is their exact position" of position and location, is the same in Chinese. :) |
Thanks. Merged. |
First, all of the English strings from /app/src/main/res/values/strings.xml has been translated. The original file contains 291 strings, and I added & translated new 93 strings from the English file, and improved some translating too.
Besides, I reordered the strings to keep consistency with English strings.xml, which could be very helpful to stay the latest for further updates.
However, I don't have any experience with compelling Android apps, so the above changes is never been tested.
It's very important to test this new translate file, to avoid full screen of R#%#&#&*)@(IDHDBKJB. ^^