Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update COMPATIBLE_DEVICES.md #231

Merged
merged 3 commits into from
Feb 16, 2019
Merged

Update COMPATIBLE_DEVICES.md #231

merged 3 commits into from
Feb 16, 2019

Conversation

HrBDev
Copy link
Contributor

@HrBDev HrBDev commented Feb 6, 2019

No description provided.

@ikarus23
Copy link
Owner

ikarus23 commented Feb 6, 2019

Thanks! I don't want to sound too strict, but can you please add a space before the "(" ?

@HrBDev
Copy link
Contributor Author

HrBDev commented Feb 6, 2019

of course, I don't know how I missed the space.
Also, I've got a quick question:
Are you still interested in developing this app? like refactoring or adding support for newer Mifare cards? or a whole new app using the Mifare provided library?

@ikarus23
Copy link
Owner

ikarus23 commented Feb 7, 2019

Thank you.

Are you still interested in developing this app?

Yes, but I don't think there will be massive changes. I just don't have the time.

like refactoring

Refactoring would be great. The code is bad, so there is a lot to refactor. But as I said, I just don't have the time. Therefore, I think I will keep the base.

or adding support for newer Mifare cards?

No, it will stay Mifare Classic only. The other Mifare products are just to different from Classic. I like the UNIX philosophy here: One tool for one job. Mifare Ultralight or DESFire are differnt jobs ;)

or a whole new app using the Mifare provided library?

I will not use the library provided by Mifare. At least not for this app. It is closed source and "tracks" you (needs internet permissions (among others) to check the developer key for the SDK).

@HrBDev
Copy link
Contributor Author

HrBDev commented Feb 7, 2019

Thanks for the answers.

@ikarus23 ikarus23 merged commit a41d890 into ikarus23:master Feb 16, 2019
@ikarus23
Copy link
Owner

Thanks.

@HrBDev HrBDev deleted the patch-1 branch June 29, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants