Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update COMPATIBLE_DEVICES.md #193

Closed
wants to merge 1 commit into from

Conversation

archang3l-media
Copy link

Added the Moto G5 Plus to working devices.
Tested today with Lineage OS ROM

Added the Moto G5 Plus to working devices.
Tested today with Lineage OS ROM
@sesam
Copy link

sesam commented Sep 4, 2018

Ping @ikarus23

@ikarus23
Copy link
Owner

ikarus23 commented Sep 5, 2018

Not sure if I want to merge this if it was "only" tested on Linage OS and not the official stock rom. I heard of devices in the past which worked with Linage OS but not with the stock rom. This leads to a lot of complains on Google Play.

Maybe I will just add it to the list of compatible devices with the remark to "tested on Linage OS". But if it's on the device blacklist on Google Play I will keep it there until someone tested it with the stock rom. (I'm not sure if the Moto G5 Plus is on the blacklist in Google Play. I will check it when I'm back from holidays.)

@ikarus23
Copy link
Owner

According to https://www.shopnfc.com/en/content/7-nfc-compatibility the Moto G5 Plus is well known for working with Mifare Classic.

@archang3l-media Sorry for being so over correct, but would you mind to reopen this pull request and keep the alphabetical order of the list? ("G5 Plus" over "Photon Q"). I can do it my self if you want but then you won't be listed as contributor on github in the same way.

@ikarus23
Copy link
Owner

Added in 385ea0b.

@ikarus23 ikarus23 closed this Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants