Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App data storage #103

Closed
osysltd opened this issue Oct 26, 2016 · 12 comments
Closed

App data storage #103

osysltd opened this issue Oct 26, 2016 · 12 comments
Labels
Milestone

Comments

@osysltd
Copy link

osysltd commented Oct 26, 2016

Dear Ikarus,

First of all thank you for such high quality development!

A quick question\feature request:
Is it feasible to store the app data in the /data partition (or add an option to store the info there) as this is the only place which is being encrypted on the encryption-enabled smartphone. The aim is to be on the safe side having custom dictionary keys and dumps and prevent unauthorized access to the information.

Thank you.

@ikarus23
Copy link
Owner

Hi osys,
this seams like a reasonable option. I put the data on the external memory so everybody can
easily backup or modify them and they do not get lost if the app gets uninstalled. However, if
you store real secret keys then of course it would be best to store them in the /data partition.
I will add an option that allows you to switch between internal and external memory. But as
always, I'm not sure when I will have the spare time to implement it. ;)

@ikarus23 ikarus23 added this to the Todo milestone Mar 4, 2017
@ikarus23
Copy link
Owner

ikarus23 commented Mar 5, 2017

I implemented this feature. You can try it using this MCT testing version. There will be a release containing this feature once I had a look into some other construction sites of MCT.

@bxl0608
Copy link

bxl0608 commented Mar 5, 2017 via email

@osysltd
Copy link
Author

osysltd commented Mar 5, 2017

Unfortunately I cannot install on Android 5.1.1.
*** Previous version from GooglePlay uninstalled

@ikarus23
Copy link
Owner

ikarus23 commented Mar 5, 2017

Yes, you cannot have both versions installed at the same time. You have to uninstall MCT before you install this version. Your dumps and key files will survive this. However, if you use the "save on internal storage" option from this version, all data in the internal storage will be gone once you uninstall it again. Have a look at the information on the new option, which are available within the app.

@ikarus23
Copy link
Owner

ikarus23 commented Mar 5, 2017

Maybe I will add an import/export function for files from and to the internal storage. But I'm not sure if that's worth the effort. If the keys in your key file are that secret, you probably should not carry them on your phone all the time...

@osysltd
Copy link
Author

osysltd commented Mar 5, 2017

Previous version from GooglePlay was uninstalled prior to the installation.

@ikarus23
Copy link
Owner

ikarus23 commented Mar 8, 2017

Maybe I should have read you comment more carefully... Sorry.

Well, I rebuild the app using the old app signing method. Now it should work. I substituted the apk in the link above. Just download it again.

@osysltd
Copy link
Author

osysltd commented Mar 10, 2017

Dear Ikarus,
Thank you for your reply. I've deleted any mct from device and installed the latest version. In the settings set up the option to use the internal storage, however can see that the storage folder is appearing in two places: /storage/emulated/0/MifareClassicTool and also /data/data/de.syss/MifareClassicTool. Is that expected? Default key files are equal in these places. Ive also deleted these folders but they reappeared both of them after relaunching the app. Btw fyi the only encrypted folder is /data/data/de.syss... the other one can be viewed from custom recovery for example.

@ikarus23
Copy link
Owner

Hi @osysltd, yes this is expected. MCT creates the basic structure at both places. I know that only data at /data/data/... is protected. As long as you use the new option new key and dump files will be stored at /data/data. You can switch when ever you want.

@osysltd
Copy link
Author

osysltd commented Mar 10, 2017

Cool! thank you very much for the efforts, now mct users can be on the safe side.

@ikarus23
Copy link
Owner

You are welcome. Thank you for testing!

@osysltd osysltd closed this as completed Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants