-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address tests that are flaky on GHA #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #712 +/- ##
=======================================
- Coverage 94.4% 94.4% -0.1%
=======================================
Files 43 43
Lines 3449 3448 -1
=======================================
- Hits 3258 3257 -1
Misses 191 191
|
Mark westeros_report tutorial xfail on Python 3.11.
We still see the following for macOS; all Python versions; for the R_austria tutorials:
|
See iiasa/ixmp#479 for a related issue without solution as of now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tutorial tests are "flaky": they occasionally fail on the GitHub Actions runners, e.g. here. This necessitates daily work to restart the CI runs.
Per the Pytest docs on flaky tests, this PR:
pytest-rerunfailures
to the tests dependencies.Also:
float(…)
to get a single value from a pandas.DataFrame; usingDataFrame.at[…]
or.item()
instead.How to review
Confirm at least one instance where a test initially fails, and the usage of the plugin succeeds in allowing the test to pass on re-run.
This should appear somewhat like this in the log output:
→ here, at L314, re-run at L318, and summarized at L17008.
PR checklist
Add, expand, or update documentation.N/A, testing onlyUpdate release notes.