Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests that firstmodelyear is cloned correctly #212

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

danielhuppmann
Copy link
Member

This PR extends the integration tests to prevent the recurrence of the bug detected by @OFR-IIASA where the mapping set cat_year was not correctly cloned. The bug itself was fixed in the Java core by iiasa/ixmp#156.

@khaeru khaeru added this to the 1.2 milestone Jun 24, 2019
@khaeru khaeru added the bug Doesn't work as advertised/unintended effects label Jun 24, 2019
Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good & tests pass!

Copy link
Contributor

@OFR-IIASA OFR-IIASA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!

@khaeru khaeru merged commit 5c930c1 into iiasa:master Jun 25, 2019
@danielhuppmann danielhuppmann deleted the hotfix/clone_firstmodelyear branch June 27, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Doesn't work as advertised/unintended effects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants