Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2-platform cloning & associated tests #182

Merged
merged 4 commits into from
Apr 1, 2019
Merged

Fix 2-platform cloning & associated tests #182

merged 4 commits into from
Apr 1, 2019

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Apr 1, 2019 •
edited
Loading

This PR…

PR checklist:

  • Tests added
  • Documentation added
  • Description in RELEASE_NOTES.md added

@khaeru khaeru changed the title Fix platform cloning & associated tests Fix 2-platform cloning & associated tests Apr 1, 2019
@khaeru khaeru self-assigned this Apr 1, 2019
@gidden
Copy link
Member

gidden commented Apr 1, 2019

g2g here for review @khaeru ?

@gidden
Copy link
Member

gidden commented Apr 1, 2019

Ah, some test failures, I'll wait to review until passage

@khaeru
Copy link
Member Author

khaeru commented Apr 1, 2019

The tests will not pass until ixmp#132 is merged.

@gidden
Copy link
Member

gidden commented Apr 1, 2019

Ok, merged ixmp/#132 and restarted CI

@gidden
Copy link
Member

gidden commented Apr 1, 2019

Looks great, thank you @khaeru !!

@khaeru khaeru requested a review from gidden April 1, 2019 14:40
@gidden gidden merged commit d9b5033 into iiasa:master Apr 1, 2019
@khaeru khaeru added this to the 1.2.0 milestone Apr 1, 2019
@khaeru khaeru deleted the issue/174 branch April 1, 2019 14:41
@khaeru khaeru removed the request for review from gidden April 1, 2019 14:43
@khaeru khaeru mentioned this pull request May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@khaeru khaeru

Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

platform cloning broken in message_ix
2 participants
@khaeru @gidden