Scenci #109
Merged
Scenci #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Sep 6, 2018
message_ix/core.py
Outdated
| """Read Excel file data and load into the scenario. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| fname : string | ||
| path to file | ||
| add_units : bool | ||
| add missing units, if any, to the platform instance. default: False |
There was a problem hiding this comment.
E501 line too long (80 > 79 characters)
stickler-ci
reviewed
Sep 6, 2018
tests/ci/download_db.py
Outdated
| username = os.environ['MESSAGE_IX_CI_USER'] | ||
| password = os.environ['MESSAGE_IX_CI_PW'] | ||
|
|
||
| url = 'https://data.ene.iiasa.ac.at/continuous_integration/scenario_db/db.tar.gz' |
There was a problem hiding this comment.
E501 line too long (81 > 79 characters)
stickler-ci
reviewed
Sep 6, 2018
tests/ci/download_db.py
Outdated
| raise IOError( | ||
| 'Failed download with user/pass: {}/{}'.format(username, password)) | ||
|
|
||
| import glob |
There was a problem hiding this comment.
E402 module level import not at top of file
tests/ci/download_db.py
Outdated
| import glob | ||
|
|
||
| for filename in glob.iglob('./*', recursive=True): | ||
| print(filename) |
There was a problem hiding this comment.
E111 indentation is not a multiple of four
stickler-ci
reviewed
Sep 10, 2018
tests/ci/download_db.py
Outdated
| import requests | ||
| import tarfile | ||
|
|
||
| import ixmp |
tests/ci/download_db.py
Outdated
|
|
||
| import ixmp | ||
|
|
||
| from paths import dbpath |
There was a problem hiding this comment.
F401 'paths.dbpath' imported but unused
|
@OFR-IIASA I rebased this into a single commit for easier managing. Please take note if you are building more commits on top of it. |
e6aea82
to
c87d5ba
Compare
…ization for models including MACRO.
gidden
added a commit
that referenced
this pull request
Sep 17, 2018
…ization for models including MACRO. (#109)
gidden
added a commit
that referenced
this pull request
Nov 13, 2018
…ization for models including MACRO. (#109)
gidden
added a commit
that referenced
this pull request
Nov 14, 2018
…ization for models including MACRO. (#109)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108